Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Sep 6, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • fix bug in stopping condition for synchrozniation with Bkp
  • add test for synchronization with Bkp (using artifcaly generated data)
  • fix bug (spotted thanks to mentioned test) in makeHttpRequestForJSON function - there were incorrect logic for catching some fatal errors, what some times have caused app crash

Changes made to the database:

  • NA

@xsalonx xsalonx added backend bug Something isn't working refactor labels Sep 6, 2023
@xsalonx xsalonx requested a review from Ehevi September 6, 2023 09:33
@xsalonx xsalonx self-assigned this Sep 6, 2023
@xsalonx xsalonx changed the title Refactor/orct 118/bookkeeping services bugfix synchronization tests [ORCT-118] bookkeeping services bugfix synchronization tests Sep 6, 2023
@Ehevi Ehevi merged commit e175b87 into master Sep 6, 2023
@Ehevi Ehevi deleted the refactor/ORCT-118/BookkeepingServices-bugfix_synchronization-tests branch September 6, 2023 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backend bug Something isn't working refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants